Skip to content

feat: Add support for gifs in lexical#1873

Merged
zurfyx merged 2 commits intofacebook:mainfrom
rimildeyjsr:giphy-plugin-add-sample-gif
Apr 20, 2022
Merged

feat: Add support for gifs in lexical#1873
zurfyx merged 2 commits intofacebook:mainfrom
rimildeyjsr:giphy-plugin-add-sample-gif

Conversation

@rimildeyjsr
Copy link
Contributor

@rimildeyjsr rimildeyjsr commented Apr 19, 2022 •
edited
Loading

Changelog:

  • Add a button to insert a sample gif in the insert menu
  • Add a sample gif
  • Add gif icon

Relates to - #1820

Screen recording:

gif-recording.mov

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 19, 2022
@vercel
Copy link

vercel bot commented Apr 19, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Apr 19, 2022 at 4:50PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Apr 19, 2022 at 4:50PM (UTC)

@rimildeyjsr
Add support for gifs in lexical
5a7e286 
    * Add a button to insert a sample gif in the insert menu
    * Add a sample gif
    * Add gif icon
@rimildeyjsr rimildeyjsr force-pushed the giphy-plugin-add-sample-gif branch from d7bc076 to 5a7e286 Compare April 19, 2022 14:54
@rimildeyjsr rimildeyjsr changed the title Add support for gifs in lexical feat: Add support for gifs in lexical Apr 19, 2022
@rimildeyjsr rimildeyjsr marked this pull request as ready for review April 19, 2022 15:01
@trueadm
Copy link
Collaborator

trueadm commented Apr 19, 2022

Thanks for this. How is it different from just using the gif URL on the insert image workflow though?

@rimildeyjsr
Copy link
Contributor Author

rimildeyjsr commented Apr 19, 2022

Thanks for this. How is it different from just using the gif URL on the insert image workflow though?

@trueadm - I am working on a complete feature to introduce adding gifs to the editor using the GIPHY API, where we can have a modal that displays the gifs to be selected from.

As suggested by @zurfyx I am raising the first PR to only add a hard-coded gif:
#1820 (comment)

trueadm
trueadm approved these changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! :)

@zurfyx
Copy link
Member

zurfyx commented Apr 19, 2022 •
edited
Loading

That's awesome! Should we make the gif a bit smaller if we're planning to delete it later? It's 2MB that will sit in the git history forever

@zurfyx
Copy link
Member

zurfyx commented Apr 19, 2022

Also, what I meant for the first PR is whether we can display the gif just like we'd use the Giphy API but no objections for this as a first PR :)

@rimildeyjsr rimildeyjsr force-pushed the giphy-plugin-add-sample-gif branch from 3df89a7 to d1a6164 Compare April 19, 2022 16:48
@rimildeyjsr
Copy link
Contributor Author

rimildeyjsr commented Apr 19, 2022

@zurfyx - Optimised the gif!

I will start work on the API integration from the next PR onwards!

@zurfyx zurfyx merged commit 6a24e0e into facebook:main Apr 20, 2022
@wobsoriano
Copy link
Contributor

wobsoriano commented Apr 21, 2022

Maybe this can help? https://sergiop.github.io/react-giphy-searchbox/

@joncwong
Copy link

joncwong commented Nov 4, 2024

Does this only add support for gifs in the playground and not as a plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trueadm trueadm trueadm approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rimildeyjsr @trueadm @zurfyx @wobsoriano @joncwong @facebook-github-bot